Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Morse->Shannon Migration] feat: implement Morse account state upload #1047
[Morse->Shannon Migration] feat: implement Morse account state upload #1047
Changes from all commits
71f5112
0180b2f
7c42e21
1add213
132938d
dad4fe4
e0a6d4b
923373b
31f879a
7ef355f
1a314f1
3009a85
f7fc70a
b8c2eff
a822c23
a80f643
e38baee
170875e
aade27e
59cada2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.Error
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.Error()
should ONLY be used for server-side errors (i.e. operator attention required), not client-side errors.Node operators are the primary "user" (in a UX sense) of the log output. As such, any error which does not require operator attention SHOULD NOT use any level other than "debug"; however, due to reasons outlined in #856, we've decided to use the "info" level on-chain for both "info" and "debug" logs.
CreateMorseAccountState
method is already captured by the.With("method", ...)
above.sdkerrors.ErrInvalidAddress.Wrapf("invalid authority address (%s)", err)
ErrMorseAccountState.Wrapf("expected hash is empty")
ErrMorseAccountState.Wrapf("Morse account state hash (%x) doesn't match expected: (%x)", actualHash, expectedHash)
Do you feel that these errors, combined with the
InvalidArgument
status code, are ambiguous any sense?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto here and elsewhere.
Not leaving any more comments so might be worth a ctrl+f for
logger.Info(err.Error())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #1047 (comment)