chore: Deprecate the old streaming engine #20949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Information on the new streaming engine: pola-rs#20947.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20949 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.02%
==========================================
Files 1578 1578
Lines 224156 224207 +51
Branches 2576 2576
==========================================
+ Hits 177762 177768 +6
- Misses 45803 45848 +45
Partials 591 591 ☔ View full report in Codecov by Sentry. |
eitsupi
reviewed
Feb 8, 2025
Comment on lines
+77
to
+80
| The old streaming engine is being deprecated and will soon be replaced by the new streaming \ | ||
| engine. Starting Polars version 1.23.0 and until the new streaming engine is released, the old \ | ||
| streaming engine may become less usable. For people who rely on the old streaming engine, it is \ | ||
| suggested to pin your version to before 1.23.0. |
There was a problem hiding this comment.
Since this shows the version of Python Polars, wouldn't there be confusion if this were called on a non-Python API?
There was a problem hiding this comment.
Yeah, we should flag that whole branch with #cfg[feature = "python"].
In rust we don't deprecate and will remove it in a breaking release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information on the new streaming engine: #20947.