Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support sub json path for JsonReader #21226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eranfu
Copy link

@eranfu eranfu commented Feb 13, 2025

Users can use it to parse the partial data from the json. See the comment of with_sub_json_path for example.

@eranfu eranfu force-pushed the feat-sub-json-reader branch from b60fea8 to 3bf1cf5 Compare February 13, 2025 06:36
@eranfu eranfu changed the title feat: with_sub_json_path for JsonReader feat: Support sub json path for JsonReader Feb 13, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 86.76471% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (0654544) to head (999dba7).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/json/mod.rs 86.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21226      +/-   ##
==========================================
- Coverage   79.88%   79.80%   -0.09%     
==========================================
  Files        1593     1596       +3     
  Lines      227754   228488     +734     
  Branches     2600     2607       +7     
==========================================
+ Hits       181937   182337     +400     
- Misses      45220    45555     +335     
+ Partials      597      596       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eranfu eranfu force-pushed the feat-sub-json-reader branch from 3bf1cf5 to 999dba7 Compare February 14, 2025 13:44
@ritchie46
Copy link
Member

This seems useful. However, this has to be exposed on the Lazy Readers and the Python API as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants