Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite recursion when broadcasting into struct zip_outer_validity #21268

Conversation

coastalwhite
Copy link
Collaborator

Fixes #21267.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (4ef23d8) to head (e2852c7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-core/src/chunked_array/comparison/mod.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21268   +/-   ##
=======================================
  Coverage   79.87%   79.87%           
=======================================
  Files        1596     1596           
  Lines      228470   228489   +19     
  Branches     2607     2607           
=======================================
+ Hits       182488   182515   +27     
+ Misses      45386    45378    -8     
  Partials      596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite merged commit 1e16f14 into pola-rs:main Feb 14, 2025
27 checks passed
@coastalwhite coastalwhite deleted the fix/struct_zip_outer_validity_segfault_21267 branch February 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite recursion when performing __eq__ on Struct.
1 participant