fix(rust): Fix inconsistency between code and comment #21294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YichiZhang0613
requested review from
ritchie46,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21294 +/- ##
==========================================
- Coverage 79.82% 79.82% -0.01%
==========================================
Files 1596 1596
Lines 228565 228561 -4
Branches 2608 2608
==========================================
- Hits 182462 182455 -7
- Misses 45507 45510 +3
Partials 596 596 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Feb 17, 2025
| @@ -22,6 +22,7 @@ impl<'a> GrowableFixedSizeBinary<'a> { | |||
| mut use_validity: bool, | |||
| capacity: usize, | |||
| ) -> Self { | |||
| assert!(!arrays.is_empty()); | |||
There was a problem hiding this comment.
It already panics because of access on L32.
ritchie46
reviewed
Feb 17, 2025
| @@ -24,6 +24,7 @@ impl<'a, T: NativeType> GrowablePrimitive<'a, T> { | |||
| mut use_validity: bool, | |||
| capacity: usize, | |||
| ) -> Self { | |||
| assert!(!arrays.is_empty()); | |||
There was a problem hiding this comment.
It already panics because of access on L34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes problems in #21228