fix: Resolve deadlock due to leaking in Connector recv drop #21296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that made values in the
Connector
channel leak if the receiver was dropped before the value was received.In the receiver drop it now:
The reason this resolves a deadlock is because we were sending
WaitToken
s that we rely on dropping through the channel. If those aren't dropped the associatedWaitGroup
will never unblock.