Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove new streaming old multiscan #21300

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 17, 2025
@coastalwhite coastalwhite marked this pull request as draft February 17, 2025 15:33
@coastalwhite coastalwhite force-pushed the refactor/remove-new-streaming-old-multiscan branch from fa59f2f to 0ad99df Compare February 17, 2025 16:42
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 85.86387% with 27 lines in your changes missing coverage. Please review.

Project coverage is 79.90%. Comparing base (5e51218) to head (0ad99df).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/ir/scan_sources.rs 52.63% 18 Missing ⚠️
crates/polars-stream/src/nodes/io_sources/csv.rs 90.90% 8 Missing ⚠️
crates/polars-plan/src/plans/conversion/scans.rs 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21300      +/-   ##
==========================================
+ Coverage   79.82%   79.90%   +0.07%     
==========================================
  Files        1596     1596              
  Lines      228565   228595      +30     
  Branches     2608     2608              
==========================================
+ Hits       182462   182666     +204     
+ Misses      45507    45333     -174     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as ready for review February 17, 2025 17:03
@coastalwhite coastalwhite merged commit eae47a4 into pola-rs:main Feb 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant