Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to rand v0.9 #21374

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 20, 2025
@ritchie46
Copy link
Member

Note that we don't guarantee stable seeds/randomness between versions, so the failing tests may be updated if that the cause.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 64.10256% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.98%. Comparing base (fe94069) to head (14a5c92).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/chunked_array/random.rs 11.11% 8 Missing ⚠️
crates/polars-arrow/src/bitmap/utils/mod.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21374      +/-   ##
==========================================
+ Coverage   79.91%   79.98%   +0.06%     
==========================================
  Files        1597     1597              
  Lines      228713   228838     +125     
  Branches     2618     2618              
==========================================
+ Hits       182775   183032     +257     
+ Misses      45339    45207     -132     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite
Copy link
Collaborator Author

Blocked on seanmonstar/reqwest#2560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants