Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Secure WebSockets #293

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Setup Secure WebSockets #293

wants to merge 5 commits into from

Conversation

CrackTheCode016
Copy link
Collaborator

Previous PR for reference: #35

@CrackTheCode016 CrackTheCode016 requested a review from a team as a code owner January 6, 2025 13:45
@0xLucca 0xLucca requested a review from a team January 6, 2025 13:58
dawnkelly09
dawnkelly09 requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few things. Thanks!

infrastructure/running-a-node/.pages Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
infrastructure/running-a-node/setup-secure-wss.md Outdated Show resolved Hide resolved
kianenigma
kianenigma reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only there was a way to test this content too 🙈

can we use something like docker-compose to both make this setup easier to achieve, and test-able?

@eshaben eshaben added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A0 - New Content Pull request contains new content pages labels Jan 13, 2025
@eshaben
Copy link
Collaborator

eshaben commented Jan 23, 2025

@CrackTheCode016 things seemed to have gone stale with this PR. Anything we can help out with on our end?

@nhussein11
Copy link
Collaborator

Hey, jumping in here so we can proceed with this PR

@nhussein11 nhussein11 mentioned this pull request Feb 5, 2025
Open
@nhussein11
Copy link
Collaborator

If only there was a way to test this content too 🙈

can we use something like docker-compose to both make this setup easier to achieve, and test-able?

I created an issue to refactor this guide to implement docker-compose #366 (comment)

0xLucca
0xLucca approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dawnkelly09
dawnkelly09 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you for getting this across the finish line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma left review comments

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@0xLucca 0xLucca 0xLucca approved these changes

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrackTheCode016 @eshaben @nhussein11 @kianenigma @dawnkelly09 @0xLucca