Ensure rpc-core can correctly decode types, even if multiple types share the same name#6089
Conversation
… avoid issues with multiple types that share the same name
|
Hey thanks for the PR. Were you able to check in apps if it works? The way you can link the api with your changes is by having apps share the same root directory as the api - and running |
|
I checked this blockhash: |
|
you are correct. this only fixes the issue that storage items with the same type name could not be decoded. for calls/extrinsics, more work is needed. |
|
would it still be possible to merge this fix? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently, rpc-core tries to decode the results of a storage query by using the type name. However, it is perfectly valid to have multiple, different types in the type registry that share the same name. In this case rpc-core will fail to decode. This change uses the unique type id for decoding if available instead.
This change fixes polkadot-js/apps#10432