Skip to content

Conversation

@Drenayaz
Copy link
Collaborator

@Drenayaz Drenayaz commented Feb 8, 2024

No description provided.

@Drenayaz Drenayaz self-assigned this Feb 8, 2024
@Drenayaz Drenayaz linked an issue Feb 8, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
83 60 72% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: d544617 by action🐍

@pierre-rouanet
Copy link
Member

Really nice!

I'm just adding some comments regarding the overall doc/API here for tracking:

  • I think it would be nice to add a figure with the frame used by the IK directly within the README (robot frame and end-effector frame ?)
  • I'm not sure but I think your goal_pose is defined differently in symbolic vs control IK (6d array vs 4x4 matrix)? Is that correct, maybe adding a few lines or a link to the API could be nice (typically to specify input/output format - type of vectors, degrees/radians, etc.).
  • Some info regarding compute time?
  • Maybe a contributing section with maybe links to some open issues (eg. I think at some points we talked about vectorization to handles multiples IK computation at once).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation

3 participants