Make poly-xxx-mode minor mode maps instantly available for evil users #228
Conversation
srnnkls
changed the title
|
See polymode/poly-org#14. |
| @@ -325,7 +325,8 @@ changes." | |||
| (evil-change-state old-state)))))) | |||
|
|
|||
| (eval-after-load 'evil-core | |||
| '(add-hook 'polymode-after-switch-buffer-hook 'polymode-switch-buffer-keep-evil-state-maybe)) | |||
| '(add-hook 'polymode-after-switch-buffer-hook 'polymode-switch-buffer-keep-evil-state-maybe) | |||
| '(add-hook 'polymode-init-inner-hook #'evil-normalize-keymaps)) | |||
There was a problem hiding this comment.
This is probably ok, but can this be moved to the polymode-switch-buffer-keep-evil-state-maybe somehow? Basically, is there a way to check if keymaps are not installed and call evil-normalize-keymaps conditionally only when needed?
I think this problem occurs only when old-state is the same as new-state and is 'normal. I am just concerned that such unconditional keymap normalization can mess up with people who have evil loaded but not using it. What do you think?
|
Sorry for the silence. Our baby arrived on Wednesday. I do understand what you are trying to achieve and going to get my head around it more within the coming week. |
Beautiful. Congrats! Please take your time. If you cannot find time for it in the upcoming weeks I will either merge what you have or will try to figure out myself by browsing evil's code. Thanks anyhow. |
No description provided.