Creating Stories for Card, Banner, Media with Caption. #7
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jenbreese
changed the title
|
I'm not sure how much details the VS code in gitpod provides. My phpstorm tells me this: You can look at the card.stories.tsx and see how the |
|
I added classes for the Media caption. I added the |
|
@jenbreese I don't understand what you mean by "nextjs version of the site". It looks like your story book story is working correctly for the media with caption. |
|
I thought it has to work on the Storybook (port 6006) and the port 3000 site where the file |
|
Oh thank you. It was missing from the GQL queries. You can see where I added the missing fields in the fragments here: d5e5297 |
|
@pookmish Thank you thank you thank you. |
| {paragraph.suBannerSupHeader} | ||
| </div> | ||
| } | ||
|
|
||
| <Wysiwyg html={paragraph.suBannerBody?.processed} className="order-3"/> | ||
| <Wysiwyg html={paragraph.suBannerBody?.processed} className="order-3 text-m0"/> |
There was a problem hiding this comment.
There is a 100ch width applied to the p within this. It keeps it from aligning flush right to the image edge. @pookmish Do you know the best way to fix that?
There was a problem hiding this comment.
I'm not sure I know what you mean. when should the text align to the image edge of the banner?
There was a problem hiding this comment.
I'm sorry @pookmish That comment should have gone on the media with caption file.
There was a problem hiding this comment.
Ok, but from what I see, it is aligning to the right of the image. I'm not sure what you are seeing different
There was a problem hiding this comment.
Well, it is right aligned fine now for me too. 🤷🏼♀️
* Minor search box edits * fixup to color * fixup
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test