-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Snap Window Edges to Close Output Edges #1189
Conversation
My initial impression of this code-wise is very good. Thanks for working on this! I'll give it an in-depth review (and most likely merge as is), if @pop-os/ux agrees with this feature. |
49ec379
to
4b1c0ba
Compare
So the verdict is, that we want this behind a cosmic-comp config setting that is off by default (but will be exposed in cosmic-settings). Could you add this to the PR? If not that is also totally fine, in that case I'll do it, once I have the time. In any case thanks for working on this 👍 |
Done. I've also made the actual snapping distance configurable too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've also made the actual snapping distance configurable too.
Great! I think that makes for a great config option, though we will probably expose this in cosmic-settings purely as a toggle for now.
a13a17e
to
f627a92
Compare
Thanks again! |
Aur naur, I forgot to rename the |
If you feel like it, feel free to submit a PR correcting that. :) |
This is a feature that KDE has called "Snap Zones" which I find to be very useful for organizing floating layouts (especially small widgets like the Spotify miniplayer, demonstrated in the video).
When resizing or moving a floating/sticky window, any edge that gets too close to one of the currently active output's edges will be snapped into the output's edge, mitigating any pixel-perfect movements you would have to do otherwise to get window edges to align properly.
magnetc-window.mp4