panel-config: Add border_width property #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new property to the panel config, which allows users to specify a border for the panel. Signed-off-by: Ryan Brue <[email protected]>
Signed-off-by: Ryan Brue <[email protected]>
|
Needs approval by @maria-komarova. Probably fine since it's not enabled by default. |
|
It's all right to add the property as long as it doesn't change the defaults. |
|
There seems to be a bug relating to how the border is drawn, as it doesn't line up correctly when I've tested it. |
Could be because I used the iced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new property to the panel config, which allows users to specify a border for the panel.
The default is 0.0, and we don't expose this property in cosmic-settings.
Design approval pending :)
Example of a border_width of 1.0: