Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.rb: Undeprecate HOMEBREW_BUILD_FROM_SOURCE #5

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

RandomDSdevel
Copy link
Member

@RandomDSdevel RandomDSdevel commented Jan 18, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? (Partly, see my commit message.)
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally? (All tests pass locally except 'test/os/mac_spec.rb,' which fails with an unrelated error stating that, "'Locale::parse' failed to parse 'OS::Mac::language'.")

     I'm leaving this open for the time being instead of merging it immediately, at least until we formally decide on how to proceed with #2.

@RandomDSdevel RandomDSdevel self-assigned this Jan 18, 2019
@RandomDSdevel RandomDSdevel requested a review from a team January 18, 2019 03:51
@RandomDSdevel RandomDSdevel added the enhancement New feature or request label Jan 18, 2019
@RandomDSdevel RandomDSdevel changed the base branch from master to stable January 18, 2019 04:00
@rw rw self-requested a review January 18, 2019 04:11
@RandomDSdevel RandomDSdevel force-pushed the undeprecate-HOMEBREW_BUILD_FROM_SOURCE branch from 65728c3 to ff1619e Compare January 25, 2019 03:57
@RandomDSdevel RandomDSdevel changed the base branch from stable to master January 25, 2019 04:16
@RandomDSdevel
Copy link
Member Author

RandomDSdevel commented Jan 25, 2019

     I'm keeping this as rebased against the latest upstream commits as I can while #2 is still pending, though I'm also tracking developments there in terms of what branch this PR is against.

@RandomDSdevel
Copy link
Member Author

     Almost/sort-of/kind-of/nearly forgot to come back and merge this PR now that we've settled on a branch-usage workflow in #2.

@RandomDSdevel RandomDSdevel merged this pull request into master Jan 27, 2019
@RandomDSdevel RandomDSdevel deleted the undeprecate-HOMEBREW_BUILD_FROM_SOURCE branch January 27, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants