Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse: Operator and instances #5708

Merged
merged 21 commits into from
Feb 11, 2025
Merged

ClickHouse: Operator and instances #5708

merged 21 commits into from
Feb 11, 2025

Conversation

nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Sep 12, 2024

Signed-off-by: Nicolas Lamirault [email protected]

Summary by CodeRabbit

  • New Features
    • Added a new ClickHouse operator to the deployment framework, expanding your database management options.
    • Introduced a dedicated package with dependency management and licensing for seamless integration.
    • Enabled enhanced testing and resource configuration for improved deployment flexibility.
    • Integrated monitoring enhancements, including dynamic Grafana dashboards and pod metrics for better observability.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault added priority/medium This issue or PR may be useful, and needs some attention status/in_progress This issue or PR is being worked on, and has someone assigned kind/feature Categorizes issue or PR as related to a new feature area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Sep 12, 2024
@nlamirault nlamirault self-assigned this Sep 12, 2024
@github-actions github-actions bot added cloud/homelab Cloud Provider / Homelab size/l Size L labels Sep 12, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault changed the title Clickouse: Operator and instances ClickHouse: Operator and instances Sep 12, 2024
Signed-off-by: Nicolas Lamirault <[email protected]>
Copy link

gitguardian bot commented Sep 12, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Copy link

stale bot commented Nov 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2024
@nlamirault nlamirault removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2024
@nlamirault nlamirault added this to the v2.0.0 milestone Nov 29, 2024
Copy link

stale bot commented Jan 28, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2025
Signed-off-by: Nicolas Lamirault <[email protected]>
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2025
Copy link

coderabbitai bot commented Feb 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request expands the existing system applications by adding support for a new ClickHouse operator. A new generator entry for clickhouse-operator is added in the system’s YAML configuration, and a corresponding Helm chart is introduced. The chart includes metadata, dependencies, and multiple Kubernetes resource templates (for ClickHouse installations, Grafana dashboards, and pod monitoring). Additionally, configuration files are updated to specify resource allocations, test settings, monitoring, and dashboard management within the Talos homelab environment. Commented-out entries for other apps remain unchanged.

Changes

File(s) Change Summary
gitops/argocd/apps/system/values-talos-homelab.yaml Added new generator entry for clickhouse-operator with namespace database and target revision HEAD.
gitops/argocd/charts/database/clickhouse-operator/Chart.yaml Introduced new Helm chart with metadata, API version v2, and dependency on altinity-clickhouse-operator (v0.24.3).
gitops/argocd/charts/database/clickhouse-operator/templates/... (clickhouse-test.yaml, dashboards.yaml, podmonitor.yaml) Added new resource templates for ClickHouseInstallation, GrafanaDashboard, and PodMonitor definitions.
gitops/argocd/charts/database/clickhouse-operator/values*.yaml (values-talos-homelab.yaml, values.yaml) Added configuration sections for the ClickHouse database and operator including test settings, resource limits, monitoring, and dashboard configurations.

Sequence Diagram(s)

sequenceDiagram
    participant A as ArgoCD
    participant H as Helm Renderer
    participant K as Kubernetes Cluster

    A->>H: Trigger deployment for clickhouse-operator
    H->>K: Deploy resources (Installation, Dashboards, PodMonitor)
    K-->>A: Confirm resource creation
Loading

Poem

Hoppy days, I cheer with glee,
A new operator hops into our spree.
Helm charts dance with metadata bright,
Resources and dashboards spring to light.
In our Talos lab, changes sing and play,
A bunny’s delight on this code day!
🥕🐇 Celebrate the hop along the way!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b892ca7 and 1bb9f8b.

📒 Files selected for processing (7)
  • gitops/argocd/apps/system/values-talos-homelab.yaml (2 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/Chart.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/templates/clickhouse-test.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/templates/dashboards.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/templates/podmonitor.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/values.yaml (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nlamirault nlamirault marked this pull request as ready for review February 11, 2025 07:18
@nlamirault nlamirault merged commit 37e28c0 into master Feb 11, 2025
6 of 7 checks passed
@nlamirault nlamirault deleted the feat/clickhouse branch February 11, 2025 07:19
@dosubot dosubot bot added the dependency/argo Dependency Argo label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes cloud/homelab Cloud Provider / Homelab dependency/argo Dependency Argo kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/medium This issue or PR may be useful, and needs some attention size/l Size L status/in_progress This issue or PR is being worked on, and has someone assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant