Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Observability stack #6333

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Conversation

nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Feb 20, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a new Helm chart configuration and comprehensive templates that enhance global settings, metrics endpoints, and monitoring capabilities.
    • Added dedicated configuration files tailored for Talos homelab deployments and components of the OpenTelemetry Collector.
  • Updates

    • Migrated metrics handling from Prometheus remote write to an OTLP-based approach.
    • Simplified observability settings and refined dependency management and version control.
  • Refactor

    • Streamlined dashboard and credential configurations for enhanced clarity and maintainability.

@nlamirault nlamirault added priority/high After critical issues are fixed, these should be dealt with before any further issues status/in_progress This issue or PR is being worked on, and has someone assigned kind/feature Categorizes issue or PR as related to a new feature area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Feb 20, 2025
@nlamirault nlamirault self-assigned this Feb 20, 2025
Copy link

coderabbitai bot commented Feb 20, 2025

Warning

Rate limit exceeded

@dosubot[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f0e2412 and 506f18b.

📒 Files selected for processing (22)
  • gitops/argocd/charts/opentelemetry/alloy-otel/Chart.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/templates/alloy/_global.alloy (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/templates/alloy/endpoints/_endpoints_metrics.alloy (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/templates/alloy/metrics/_metrics_prom_operator.alloy (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/templates/configmap-metrics.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy-otel/values.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/Chart.yaml (0 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/templates/alloy/endpoints/_endpoints_metrics.alloy (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/templates/alloy/metrics/_metrics_prom_operator.alloy (3 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/templates/configmap-metrics.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/alloy/values.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/Chart.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates.old/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates/configmap-dashboards.yaml (2 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates/credentials.yaml (3 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/values-talos-homelab.yaml (2 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/values.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-operator/Chart.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-operator/values-talos-homelab.yaml (2 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-operator/values.yaml (1 hunks)

Walkthrough

The pull request introduces extensive changes across multiple Helm charts related to OpenTelemetry. A new Alloy-otel chart is added with its own templates, dependencies, and values files, while the existing Alloy chart sees major modifications, including dependency removals and a shift from Prometheus remote write to an OTLP-based metrics flow. Significant overhauls are also made to the opentelemetry-collector and opentelemetry-operator charts, with new dependencies, dashboard configurations, resource management settings, and updates to service monitor labels and rules.

Changes

File(s) Change Summary
alloy-otel/*
Chart.yaml
templates/alloy/_global.alloy
templates/alloy/endpoints/_endpoints_metrics.alloy
templates/alloy/metrics/_metrics_prom_operator.alloy
templates/configmap-metrics.yaml
values-talos-homelab.yaml
values.yaml
Introduces a new Helm chart for Alloy-otel. Adds new configuration for global settings, metrics endpoints using OTLP and Prometheus Operator setups, a ConfigMap for metrics, and environment-specific values. Dependencies for multiple Alloy components and an OCI-based alloy-mixin are defined.
alloy/*
Chart.yaml
templates/alloy/endpoints/_endpoints_metrics.alloy
templates/alloy/metrics/_metrics_prom_operator.alloy
templates/configmap-metrics.yaml
values-talos-homelab.yaml
values.yaml
Simplifies the existing Alloy chart by removing several dependency entries. Metrics configurations are restructured to use OTLP receivers/exporters. Template labels and inclusions are updated, and the observability configurations in values files are streamlined by eliminating service-specific settings.
opentelemetry-collector/*
Chart.yaml
templates.old/configmap-dashboards.yaml
templates/configmap-dashboards.yaml
templates/credentials.yaml
values-talos-homelab.yaml
values.yaml
Adds dependency entries with multiple aliases for opentelemetry-collector components. Introduces new Grafana dashboard management via ConfigMaps and GrafanaDashboard resources, adjusts credential label sourcing, restructures resource management, and overhauls observability configuration by introducing component-specific blocks (logs, metrics, traces, gateway).
opentelemetry-operator/*
Chart.yaml
values-talos-homelab.yaml
values.yaml
Updates the opentelemetry-operator dependency version and adds new configuration parameters. A replica count of 1 is specified and the node selector is updated, while serviceMonitor and prometheusRule configurations are streamlined to use updated label conventions.

Sequence Diagram(s)

sequenceDiagram
    participant App as Alloy Application
    participant Rec as OTEL Receiver (Prometheus)
    participant Exp as OTLP Exporter
    participant OTLP as External OTLP Endpoint

    App->>Rec: Emit metrics data
    Rec->>Exp: Forward metrics
    Exp->>OTLP: Export metrics to endpoint
Loading

Possibly related PRs

  • Refactoring Observability stack #6333: The changes in the main PR and the retrieved PR are related as both involve modifications to the Chart.yaml file for the alloy application, specifically regarding the dependencies and configuration of observability components.

Poem

I'm a bunny hopping through YAML fields so bright,
New charts and templates make my day light.
Metrics now flow via OTLP, smooth and neat,
Dependencies pruned, configurations complete.
I nibble on carrots of code with delight,
Celebrating these changes in a joyful, bouncy flight! 🐰🌟


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault marked this pull request as ready for review February 23, 2025 14:08
@nlamirault nlamirault merged commit 914cdab into master Feb 23, 2025
6 of 7 checks passed
@nlamirault nlamirault deleted the feat/opentelemetry-datadog branch February 23, 2025 14:08
@dosubot dosubot bot added cloud/aws Cloud Provider / Amazon AWS cloud/azure Cloud Provider / Microsoft Azure cloud/digitalocean Cloud Provider / Digital Ocean cloud/gcp Cloud Provider / Google Cloud Provider cloud/homelab Cloud Provider / Homelab cloud/scaleway Cloud Provider / Scaleway dependency/argo Dependency Argo kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes Kubernetes cloud/aws Cloud Provider / Amazon AWS cloud/azure Cloud Provider / Microsoft Azure cloud/digitalocean Cloud Provider / Digital Ocean cloud/gcp Cloud Provider / Google Cloud Provider cloud/homelab Cloud Provider / Homelab cloud/scaleway Cloud Provider / Scaleway dependency/argo Dependency Argo kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/high After critical issues are fixed, these should be dealt with before any further issues size/XXL status/in_progress This issue or PR is being worked on, and has someone assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant