Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for charts to deploy on k3s/rke2 clusters #329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dahuang-purestorage
Copy link
Contributor

Signed-off-by: dahuang [email protected]

What this PR does / why we need it:
Current charts fails to deploy on k3s cluster with issues on CSI charts. This PR adds the missing sock and annotation for successfully deployment.

  • Adding mount path for containerd.sock
  • Adding NoSchedule tolerations
  • Update CSIDriver version to v1

Which issue(s) this PR fixes (optional)
Closes #
It doesn't fix any PR but it's related work to PWX-21842

Special notes for your reviewer:
Testing notes:

  • Tested using using command: helm install --debug --namespace kube-system --generate-name . on k3s cluster.

Copy link
Contributor

@zoxpx zoxpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you isolate the needed expression as a variable:

{{- $isK3s := .Capabilities.KubeVersion.GitVersion | toString | regexFind "(k3s|rke2)" }}

... and use the variable in {{ if... }} expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants