Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add the v0.15.0 release post #568

Merged
merged 5 commits into from
Dec 20, 2024
Merged

blog: add the v0.15.0 release post #568

merged 5 commits into from
Dec 20, 2024

Conversation

rich-iannone
Copy link
Member

This adds the blog post for the v0.15.0 release of the package.

@github-actions github-actions bot temporarily deployed to pr-568 December 18, 2024 21:11 Destroyed
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (bc64116) to head (4e2a35f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          46       46           
  Lines        5381     5381           
=======================================
  Hits         4879     4879           
  Misses        502      502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pr-568 December 18, 2024 21:39 Destroyed
@rich-iannone rich-iannone marked this pull request as ready for review December 18, 2024 21:48
@rich-iannone rich-iannone requested a review from machow December 18, 2024 21:48
@github-actions github-actions bot temporarily deployed to pr-568 December 18, 2024 22:01 Destroyed
@github-actions github-actions bot temporarily deployed to pr-568 December 18, 2024 22:03 Destroyed
Copy link
Collaborator

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I left some quick thoughts on shortening polars code, but feel free to ignore!

peeps_mini = (
pl.from_pandas(peeps)
.filter(pl.col("dob").str.slice(offset=0, length=4) == "1988")
.with_columns(name=pl.concat_str(pl.col("name_given") + " " + pl.col("name_family")))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the pl.concat_str() call here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

pl.from_pandas(films)
.filter(pl.col("director") == "Michael Haneke")
.with_columns(
title=pl.concat_str(pl.col("title") + " (" + pl.col("year").cast(pl.String) + ")")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove concat_str()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now changed.

.tail(10)
.with_columns(
lines=pl.lit("train"),
connect_tramway = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would define the services column here, instead of separately below. (So replace connect_tramway = with services=)

Something like removing the need for lines=, and just using...

    .with_columns(
        services = (
            pl.when(pl.col("connect_tramway").is_not_null())
            .then(pl.lit("train, train-tram"))
            .otherwise("train")
        )
    )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Now fixed!

@rich-iannone
Copy link
Member Author

Looks great, I left some quick thoughts on shortening polars code, but feel free to ignore!

Thanks for the great suggestions on improving the Polars code. Will fix up all of these shortly!

@rich-iannone rich-iannone requested a review from machow December 19, 2024 21:44
@machow machow merged commit 2a11434 into main Dec 20, 2024
13 of 14 checks passed
@machow
Copy link
Collaborator

machow commented Dec 20, 2024

This post is a smooth read!

@rich-iannone rich-iannone deleted the docs-blog-v0.15.0 branch December 20, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants