Skip to content

Commit

Permalink
fix: don't set spec.updateStrategy.maxSurge of DaemonSet by default
Browse files Browse the repository at this point in the history
  • Loading branch information
justin0u0 committed Oct 2, 2024
1 parent cd56ef0 commit 3facb9c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion helm/kubenurse/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ spec:
{{- include "kubenurse.selectorLabels" . | nindent 6 }}
updateStrategy:
rollingUpdate:
maxSurge: 0
{{- with .Values.daemonset.rollingUpdate.maxSurge }}
maxSurge: {{ . }}
{{- end }}
maxUnavailable: {{ .Values.daemonset.rollingUpdate.maxUnavailable }}
type: RollingUpdate
template:
Expand Down
1 change: 1 addition & 0 deletions helm/kubenurse/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ daemonset:
priorityClassName: ""
rollingUpdate:
maxUnavailable: 34%
# maxSurge:

serviceMonitor:
enabled: false
Expand Down

0 comments on commit 3facb9c

Please sign in to comment.