Skip to content

Postgres 12 + postgis 3 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Feb 5, 2020

Original PR: #151
The original PR may stopped so I rewrite PR.

@smellman
Copy link
Contributor Author

smellman commented Feb 6, 2020

This PR fail in wget command...

@smellman
Copy link
Contributor Author

smellman commented Feb 6, 2020

@md5 Can you retry travis-ci?
https://travis-ci.org/appropriate/docker-postgis/jobs/646651624
It fail by wget command so it may pass by retry.

@smellman smellman requested a review from md5 February 6, 2020 02:28
@smellman
Copy link
Contributor Author

smellman commented Feb 6, 2020

I added travis_retry command.

@phillipross
Copy link
Contributor

Thanks @smellman

We're in the process of transitioning the github and dockerhub repos to the postgis organization and verifying the pipelines still work, so please don't be alarmed if you see errors showing up in this PR. We'll review it once we get the infrastructure changed ironed out.

@smellman
Copy link
Contributor Author

I will re-write my PR after #166 marged

@phillipross
Copy link
Contributor

Thanks @smellman

My first comment is that we'd like maintain a 2.5 and 3.x release both, as well as postgres 9, 10, 11, and 12. The changes in your PR thus far, appear to replace postgis 2.5 with v3.0.

Also, I see changes to the update.sh script and the Dockerfiles, but no changes to the Dockerfile templates. For now we'd like to keep the builds templatized and have the update.sh script process the templates and generate the Dockerfiles in the directories that would then be used to build the images. I'm preparing changes to the script with PR #166 to make it possible to build postgis 2.5 and 3.0 both, but I won't create the directories for the 3.0. I'd like to still give you the opportunity to rewrite this PR on top of PR #166 and create the 3.0 directories and wire them in so that you're counted as a contributor 😉

In the meantime, please feel free to review and comment on PR #166 if you'd like.

@smellman
Copy link
Contributor Author

@phillipross I started from original PR that remove postgis 2.5 (without postgres 9.5) and added 3.0.
I think this reason is they didn't remove this line.
This line is discussed in other issues but anyone remove it(but I and you remove it in PR).
I just add comment to #166 to fix wget issue that my PR happened.
I have no more comment and I will try build 3.0 images.
Also I close this PR because I will re-create using your branch.

@smellman smellman closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants