feat: added reverse sorting to commitfest form

[destrex271]

Fixes #20

• Uses a new hidden form field called sortorder
• sortorder has 3 possible values
  • -1: Descending order
  • 0 : Default Order
  • 1 : Ascending order

[JelteF]

Thanks for the contribution, but I think this needs some changes.

[JelteF]

Instead of adding a new sortorder field, I think we can achieve the same by by allowing negative numbers in the sortkey. That should also make my other comment easy to address.

[destrex271]

Sounds reasonable but we actually have 3 sorting cases

• Default order
• Ascending order
• Descending order

So if we rely on negative numbers, it won't be possible to handle these cases, we can only handle ascending and descending.

If we want to avoid using a new form field, we need to come up with some crooked solution like for example

• 10 x sortkey -> ascending
• sortkey -> default
• -sortkey -> descending

Sounds good?

imo, using a new field might make the code more readable

[JelteF]

It could be I'm missing something, but I had this in mind for the meanings of the sortkey
0: topic, created (i.e. default sorting)
1: modied, created
-1: modified DESC, created DESC
...
3: num_cfs DESC, modified, created
-3: num_cfs ASC, modified DESC, created DESC
...
6: branch.all_additions + branch.all_deletions NULLS LAST, created
-6: branch.all_additions + branch.all_deletions DESC NULLS LAST, created

[destrex271]

oh okk, I thought that we wanted to just sort based on created

this makes sense, I'll make the necessary changes

[JelteF]

Thanks! And to be clear, clicking the num_cfs header should then result in this cycle:

1. sortkey = 3, with caret down in the header
2. sortkey = -3, with caret up in the header
3. sortkey = 0, without caret in the header

[JelteF]

This doesn't work when sorting by multiple columns. This will only invert the sorting for the last column. We actually need to invert the sorting for all the columns that we're sorting on. So I think we need dedicated strings for each.

[destrex271]

Ahh ok, understood. I'll make the necessary changes

[JelteF]

I added automated code formatting for JS in #29. So you'll likely have some conflicts now.

[destrex271]

cool, I'll look into it as well

[JelteF]

I rebased the main branch onto the prod branch to resolve a CI issue. Could you rebase now too, with git rebase -i just remove all the commits that you didn't write and it should be fine.

[JelteF]

Can you install Editorconfig and resave this file? Because now you removed the trailing newline that we want. https://editorconfig.org/

[JelteF]

The commits in this branch still look strange. You should be able to fix it by doing the following

git fetch
git rebase -i origin/main
# Remove the lines with commits that you didn't write
git push --force

[destrex271]

I think this has become really messy right now, how bout I create a new branch from the updated main branch ?