Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoformat js and css #29

Merged
merged 3 commits into from
Feb 15, 2025
Merged

Autoformat js and css #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2033f
Add biome formatting for js and css (#29)
JelteF Feb 15, 2025
305d384
Format files using biome (#29)
JelteF Feb 15, 2025
3d63e9f
Fix biome lints using --fix --unsafe (#29)
JelteF Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,11 @@ jobs:
uses: astral-sh/ruff-action@v2
with:
args: "format --check"

- name: Setup Biome
uses: biomejs/setup-biome@v2
with:
version: latest

- name: Run Biome
run: biome ci .
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
format:
ruff format
npx @biomejs/biome format --write

lint:
ruff check
npx @biomejs/biome check

lint-fix:
ruff check --fix
npx @biomejs/biome check --fix
36 changes: 36 additions & 0 deletions biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
{
"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
"useIgnoreFile": false
},
"files": {
"ignoreUnknown": true,
"ignore": [],
"include": [
"media/commitfest/js/commitfest.js",
"media/commitfest/css/commitfest.css",
"biome.json"
]
},
"formatter": {
"enabled": true,
"indentStyle": "space",
"indentWidth": 4
},
"organizeImports": {
"enabled": true
},
"linter": {
"enabled": true,
"rules": {
"recommended": true
}
},
"javascript": {
"formatter": {
"quoteStyle": "double"
}
}
}
36 changes: 17 additions & 19 deletions media/commitfest/css/commitfest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,47 +4,45 @@

/* For close button with float disabled */
.close-nofloat {
float: none !important;
float: none !important;
}

/* General form styling */
.form-horizontal div.form-group {
margin-bottom: 10px;
margin-bottom: 10px;
}
div.form-group div.controls ul {
list-style-type: none;
margin: 0px;
padding: 0px;
list-style-type: none;
margin: 0px;
padding: 0px;
}
div.form-group div.controls ul li {
display: inline;
display: inline;
}
div.form-group div.controls ul li label {
display: inline;
font-weight: normal;
vertical-align:middle;
display: inline;
font-weight: normal;
vertical-align: middle;
}
div.form-group div.controls ul li label input {
display: inline;
vertical-align:middle;
display: inline;
vertical-align: middle;
}
div.form-group div.controls input[type='checkbox'] {
width: 10px;
div.form-group div.controls input[type="checkbox"] {
width: 10px;
}

div.form-group div.controls input.threadpick-input {
width: 80%;
display: inline;
width: 80%;
display: inline;
}



/*
* Attach thread dialog
*/
#attachThreadListWrap.loading {
display: block;
background: url('/media/commitfest/spinner.gif') no-repeat center;
background: url("/media/commitfest/spinner.gif") no-repeat center;
width: 124px;
height: 124px;
margin: 0 auto;
Expand All @@ -57,7 +55,7 @@ div.form-group div.controls input.threadpick-input {
* Annotate message dialog */
#annotateMessageBody.loading {
display: block;
background: url('/media/commitfest/spinner.gif') no-repeat center;
background: url("/media/commitfest/spinner.gif") no-repeat center;
width: 124px;
height: 124px;
margin: 0 auto;
Expand Down
Loading