Skip to content

Adjust direction of dropdowns at the bottom of the page #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Adjust direction of dropdowns at the bottom of the page #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
500ccff
Adjust direction of dropdowns at the bottom of the page
polkerty Jan 16, 2025
2f56c8e
dropup
polkerty Jan 18, 2025
ef01a19
remove css
polkerty Jan 18, 2025
637dcc3
cleanup diff
polkerty Jan 18, 2025
d03f778
comments
polkerty Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion media/commitfest/css/commitfest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ div.form-group div.controls input.threadpick-input {
display: inline;
}


.dropdown-menu--up {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a custom class, it seems you can use the dropup class that's built into bootstrap instead (it's already used in commitfest.html). That also makes the caret point up. Other than that I think it's good the dropdown_mode thing seems to work well to isolate this to only the bottom of the page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's very nice! Updated.

top: initial;
bottom: 100%;
}

/*
* Attach thread dialog
Expand Down
2 changes: 2 additions & 0 deletions pgcommitfest/commitfest/templates/patch.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ <h4>Annotations</h4>
</tbody>
</table>

{% with dropdown_mode="dropdown-menu--up" %}
{%include "patch_commands.inc"%}
{% endwith %}

{%comment%}commit dialog{%endcomment%}
<div class="modal fade" id="commitModal" role="dialog">
Expand Down
6 changes: 3 additions & 3 deletions pgcommitfest/commitfest/templates/patch_commands.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@

<div class="btn-group">
<a class="btn btn-default dropdown-toggle" data-toggle="dropdown" href="#">Comment/Review <span class="caret"></span></a>
<ul class="dropdown-menu">
<ul class="dropdown-menu {{ dropdown_mode }}">
<li><a href="comment/">Comment</a>
<li><a href="review/">Review</a>
</ul>
</div>

<div class="btn-group">
<a class="btn btn-default dropdown-toggle" data-toggle="dropdown" href="#">Change Status <span class="caret"></span></a>
<ul class="dropdown-menu" role="menu">
<ul class="dropdown-menu {{ dropdown_mode }}" role="menu">
<li role="presentation" class="dropdown-header">Open statuses</li>
<li role="presentation"><a href="status/review/">Needs review</a></li>
<li role="presentation"><a href="status/author/">Waiting on Author</a></li>
Expand All @@ -29,7 +29,7 @@
{%if request.user.is_staff%}
<div class="btn-group">
<a class="btn btn-default dropdown-toggle" data-toggle="dropdown" href="#">Send private mail <span class="caret"></span></a>
<ul class="dropdown-menu">
<ul class="dropdown-menu {{ dropdown_mode }}" >
<li><a href="send_email/?authors={{patch.id}}">Send mail to authors</a></li>
<li><a href="send_email/?reviewers={{patch.id}}">Send mail to reviewers</a></li>
<li><a href="send_email/?authors={{patch.id}}&reviewers={{patch.id}}">Send mail to authors and reviewers</a></li>
Expand Down