Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor to decouple config from the rest of the app #135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drdrsh
Copy link
Collaborator

@drdrsh drdrsh commented Aug 20, 2022

Today, if we want to import config crate, we have to import the entire universe because reload_config references ConnectionPool and importing ConnectionPool cascades into importing the entire app.

This refactor removes reload_config from config.rs and places it in main.rs

This will allow us to import the config crate into external binaries that want to serialize/deserialize configs without having to import the entire app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant