Fix: unrecognized configuration parameter "shard" #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyang24
force-pushed
the
fix_command_setting
branch
from
f471b8b to
019c31a
Compare
|
Oh I see what's going on I think. Let me give this PR a more thorough review and I'll get back to you asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #492
Noob approach: I think that once the pool sharding regex is set we just pick shard and stopped parsing pgcat custom commands for an example . I refactor the code to swtiched the order of things that such non-custom querys will be assigned on shard if enabled, and set shard/ set shard key will override the assignment.