Promisification of functions in schemaUtils.js (ES6 Async/Await) - Enables external references for schemas and examples.

.eslintrc

@@ -13,6 +13,7 @@
       "node": true,
       "es6": true
   },
+  "parser": "babel-eslint",
   "rules": {
       // Possible Errors
       "comma-dangle": ["error", "never"],
@@ -74,7 +75,7 @@
       "no-implicit-coercion": "error",
       "no-implicit-globals": "error",
       "no-implied-eval": "error",
-      "no-invalid-this": "error",
+      "no-invalid-this": "off",
       "no-iterator": "error",
       "no-labels": "error",
       "no-lone-blocks": "error",

index.js

@@ -4,11 +4,11 @@ const SchemaPack = require('./lib/schemapack.js').SchemaPack;
 
 module.exports = {
   // Old API wrapping the new API
-  convert: function(input, options, cb) {
+  convert: async function(input, options, cb) {
     var schema = new SchemaPack(input, options);
 
     if (schema.validated) {
-      return schema.convert(cb);
+      return await schema.convert(cb);
     }
     return cb(null, schema.validationResult);
   },

lib/schemapack.js

@@ -221,7 +221,7 @@ class SchemaPack {
 
   // convert method, this is called when you want to convert a schema that you've already loaded
   // in the constructor
-  convert (callback) {
+  async convert (callback) {
     let openapi,
       options = this.computedOptions,
       analysis,
@@ -299,10 +299,14 @@ class SchemaPack {
     // For paths, All operations are grouped based on corresponding paths
     try {
       if (options.folderStrategy === 'tags') {
-        schemaUtils.addCollectionItemsUsingTags(openapi, generatedStore, componentsAndPaths, options, schemaCache);
+        await schemaUtils.addCollectionItemsUsingTags(
+          openapi, generatedStore, componentsAndPaths, options, schemaCache
+        );
       }
       else {
-        schemaUtils.addCollectionItemsUsingPaths(openapi, generatedStore, componentsAndPaths, options, schemaCache);
+        await schemaUtils.addCollectionItemsUsingPaths(
+          openapi, generatedStore, componentsAndPaths, options, schemaCache
+        );
       }
     }
     catch (e) {
@@ -333,7 +337,7 @@ class SchemaPack {
    * @param {*} callback return
    * @returns {boolean} validation
    */
-  validateTransaction(transactions, callback) {
+  async validateTransaction (transactions, callback) {
     let schema = this.openapi,
       componentsAndPaths,
       analysis,
@@ -536,13 +540,16 @@ class SchemaPack {
           }
         });
 
-        retVal = {
-          requests: _.keyBy(result, 'requestId'),
-          missingEndpoints: schemaUtils.getMissingSchemaEndpoints(schema, matchedEndpoints,
-            componentsAndPaths, options, schemaCache)
-        };
-
-        callback(null, retVal);
+        schemaUtils.getMissingSchemaEndpoints(schema, matchedEndpoints,
+          componentsAndPaths, options, schemaCache).then((resp) => {
+          retVal = {
+            requests: _.keyBy(result, 'requestId'),
+            missingEndpoints: resp
+          };
+          callback(null, retVal);
+        }).catch((e) => {
+          callback(e);
+        });
       });
     }, 0);
   }

package.json

@@ -119,6 +119,7 @@
     "ajv": "6.12.3",
     "async": "3.2.0",
     "commander": "2.20.3",
+    "isomorphic-fetch": "3.0.0",
     "js-yaml": "3.13.1",
     "json-schema-merge-allof": "0.7.0",
     "lodash": "4.17.21",
@@ -130,15 +131,16 @@
   "author": "Postman Labs <[email protected]>",
   "license": "Apache-2.0",
   "devDependencies": {
+    "babel-eslint": "10.1.0",
     "chai": "4.2.0",
     "editorconfig": "0.15.3",
     "eslint": "5.16.0",
     "eslint-plugin-jsdoc": "3.8.0",
     "eslint-plugin-mocha": "5.3.0",
     "eslint-plugin-security": "1.4.0",
     "expect.js": "0.3.1",
-    "nyc": "14.1.1",
     "mocha": "5.2.0",
+    "nyc": "14.1.1",
     "parse-gitignore": "0.5.1"
   },
   "scripts": {

test/unit/plugin.test.js

@@ -1,6 +1,6 @@
 var path = '../../',
   expect = require('expect.js'),
-  package = require(path),
+  pkg = require(path),
   packageJson = require(path + '/package.json');
 
 /* global describe, it */
@@ -17,18 +17,18 @@ describe('Plugin ' + packageJson.name, function() {
   });
 
   it('should expose the required functions', function (done) {
-    expect(typeof package.validate).to.equal('function');
-    expect(typeof package.convert).to.equal('function');
+    expect(typeof pkg.validate).to.equal('function');
+    expect(typeof pkg.convert).to.equal('function');
     done();
   });
 
   it('should validate the sample input correctly', function (done) {
-    expect(package.validate(sampleInput).result).to.equal(true);
+    expect(pkg.validate(sampleInput).result).to.equal(true);
     done();
   });
 
   it('should convert the sample input correctly', function (done) {
-    package.convert(sampleInput, {}, function(err, result) {
+    pkg.convert(sampleInput, {}, function(err, result) {
       expect(err).to.be(null);
       expect(result.result).to.equal(true);
       result.output.forEach(function (element) {