AB-454: Setup coverage report and send to looker #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test commit for re-triggering the pipelines
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Track unit-test coverage | ||
| uses: postman-eng/test-infra-scripts/.github/actions/coverage-pr-comment-action@main |
There was a problem hiding this comment.
can you change this to postmanlabs instead of postman-eng and every other place where this is being used
There was a problem hiding this comment.
Pull Request Overview
This PR sets up automated coverage reporting by configuring GitHub Actions workflows to capture and upload test coverage reports. Key changes include:
- Adding a new workflow (.github/workflows/test-infra-scripts-action.yml) for tracking unit and integration test coverage.
- Updating the integration workflow (.github/workflows/integration.yml) to capture test output using tee and correctly propagate exit codes, as well as uploading coverage artifacts.
- Introducing a condition to upload artifacts only when the Node version is 22.x.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-infra-scripts-action.yml | New workflow for tracking and commenting on test coverage. |
| .github/workflows/integration.yml | Updated test commands and artifact upload steps for coverage reports. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (4)
.github/workflows/integration.yml:23
- [nitpick] Ensure that piping using 'tee' with 'exit ${PIPESTATUS[0]}' correctly propagates the exit status of 'npm run test-unit' on the ubuntu-latest runner. Consider adding an inline comment to clarify this behavior for future maintainers.
- run: npm run test-unit | tee coverage.txt && exit ${PIPESTATUS[0]}
.github/workflows/integration.yml:45
- [nitpick] Ensure that piping using 'tee' with 'exit ${PIPESTATUS[0]}' correctly propagates the exit status of 'npm run test-regression' on the ubuntu-latest runner. Consider adding an inline comment to clarify this behavior for future maintainers.
- run: npm run test-regression | tee coverage.txt && exit ${PIPESTATUS[0]}
.github/workflows/integration.yml:25
- Verify that limiting the upload of unit test coverage artifacts to Node version 22.x is intentional, as builds using other Node versions may not upload the expected artifacts.
if: matrix.node-version == '22.x'
.github/workflows/integration.yml:47
- Verify that limiting the upload of integration test coverage artifacts to Node version 22.x is intentional, as builds using other Node versions may not upload the expected artifacts.
if: matrix.node-version == '22.x'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.