Skip to content

Bump postman-collection to 5.0.0 #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

parthverma1
Copy link
Contributor

@parthverma1 parthverma1 commented Feb 25, 2025

  • Bump postman-collection to 5.0.0
  • Drop support for Node < 18
  • Added test runs for each language separately
  • Update the CI installation step to move the dependencies (dev + distribution + test) to respective codgen packages to make them localized and uniquely identify failures for codegen language + node version

@parthverma1 parthverma1 marked this pull request as draft February 26, 2025 05:05
@parthverma1 parthverma1 marked this pull request as ready for review February 26, 2025 05:15
Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parthverma1 What was the original reason to make changes related to CI installation step for newman tests?

Let's mention it in PR description for better reference in future.

@@ -14,7 +14,7 @@
"postinstall": "node npm/deepinstall.js",
"deepinstall": "node npm/deepinstall.js",
"boilerplate": "node npm/boilerplate.js",
"cirequirements": "npm/ci-requirements.sh",
"cirequirements": "node npm/cirequirements.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to run this with elveated access i.e. sudo node npm/cirequirements.js since we're using sudo in installation scripts for various codegens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add sudo to the top script. The sudo directive is present in individual codegen where ever required.

@parthverma1
Copy link
Contributor Author

@parthverma1 What was the original reason to make changes related to CI installation step for newman tests?

Let's mention it in PR description for better reference in future.

Updated the PR description.

@VShingala
Copy link
Member

@parthverma1 These are really good improvements and significantly makes the CI faster and related steps required for debugging better.

Although, after the last change of introduction of sudo, new error has started occurring EACCES: permission denied. Can we also address it?

@VShingala VShingala merged commit 441bed6 into postmanlabs:develop Mar 10, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants