-
Notifications
You must be signed in to change notification settings - Fork 360
Bump postman-collection to 5.0.0 #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump postman-collection to 5.0.0 #788
Conversation
parthverma1
commented
Feb 25, 2025
•
edited
Loading
edited
- Bump postman-collection to 5.0.0
- Drop support for Node < 18
- Added test runs for each language separately
- Update the CI installation step to move the dependencies (dev + distribution + test) to respective codgen packages to make them localized and uniquely identify failures for codegen language + node version
…using deprecated modules
Set max parallel runs for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthverma1 What was the original reason to make changes related to CI installation step for newman tests?
Let's mention it in PR description for better reference in future.
@@ -14,7 +14,7 @@ | |||
"postinstall": "node npm/deepinstall.js", | |||
"deepinstall": "node npm/deepinstall.js", | |||
"boilerplate": "node npm/boilerplate.js", | |||
"cirequirements": "npm/ci-requirements.sh", | |||
"cirequirements": "node npm/cirequirements.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to run this with elveated access i.e. sudo node npm/cirequirements.js
since we're using sudo in installation scripts for various codegens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to add sudo to the top script. The sudo directive is present in individual codegen where ever required.
Updated the PR description. |
@parthverma1 These are really good improvements and significantly makes the CI faster and related steps required for debugging better. Although, after the last change of introduction of |
This reverts commit 4c62aeb.