Skip to content

Fix issues with deepinstall.js on windows #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtm516 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix issues with deepinstall.js on windows #799

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a6c51a
Remove touch command from yarn installation
rtm516 Oct 25, 2025
0392e49
Merge branch 'postmanlabs:develop' into patch-1
rtm516 Dec 28, 2025
53a0350
Refactor codegen installation loop to use for..of
rtm516 Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm/deepinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ async.series([
command = 'yarn install --production --frozen-lockfile';
}
else {
command = 'touch yarn.lock && yarn workspaces focus --all --production'
Copy link
Member

@shamasis shamasis Nov 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VShingala ... why would we even need to touch yarn.lock in the first place?

AI says:
touch yarn.lock updates the file’s modification timestamp without changing its contents.
Old versions of Yarn (especially v2+ “Berry”) used mtime checks to decide whether to regenerate the .pnp.cjs file or re-link workspace dependencies.
If the yarn.lock looked older than .pnp.cjs or the cache, Yarn might skip re-processing it.
So, “touching” it ensures Yarn thinks “lockfile just changed — better re-resolve workspace deps.”

Don't think this is still relevant.

command = 'yarn workspaces focus --all --production'
}
break;
case 'pnpm':
Expand Down