Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize variable replacement RegEx #1394

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

parthverma1
Copy link
Contributor

The older RegEx {{[^{}]*[&#=][^{}]*}} had a possibility of a ReDOS attack due to having polynomial complexity. The new RegEx {{[^{}]*}} encodes all variables before parsing unlike the older one which only encoded variables containing special characters.

The complexity can be checked and compared at: https://devina.io/redos-checker

Related PR: postmanlabs/postman-url-encoder#284

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8717977) to head (cced15c).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2186      2186           
  Branches       667       667           
=========================================
  Hits          2186      2186           
Flag Coverage Δ
unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant