Switch to new libpotassco.

* Enable C++20 for all code.
* Modernize code base.
* Simplify enum interface.
* Switch to clang-format based code formatting.
* Switch to "not" instead of operator!
* Switch to external catch2.
* Switch to pragma once.
* Use span instead of iterator pairs.
* Adjust URLs.

.clang-format

@@ -0,0 +1,37 @@
+---
+BasedOnStyle: LLVM
+AccessModifierOffset: -4
+AlignConsecutiveAssignments:
+  Enabled: true
+  AlignCompound: true
+AlignConsecutiveBitFields:
+  Enabled: true
+AlignConsecutiveDeclarations:
+  Enabled: true
+AlignConsecutiveMacros:
+  Enabled: true
+AlignConsecutiveShortCaseStatements:
+  Enabled: true
+  AlignCaseColons: true
+AllowShortBlocksOnASingleLine: Always
+AllowShortCaseLabelsOnASingleLine: true
+AllowShortLoopsOnASingleLine: true
+AlwaysBreakTemplateDeclarations: Yes
+BraceWrapping:
+  BeforeCatch: true
+  BeforeElse: true
+BreakBeforeBraces: Custom
+BreakConstructorInitializers: BeforeComma
+BreakInheritanceList: BeforeComma
+ColumnLimit: 120
+IndentCaseLabels: true
+IndentRequiresClause: false
+IndentWidth: 4
+KeepEmptyLinesAtTheStartOfBlocks: false
+ObjCBlockIndentWidth: 4
+PackConstructorInitializers: CurrentLine
+PointerAlignment: Left
+RequiresClausePosition: WithPreceding
+SpaceAfterCStyleCast: true
+TabWidth: 4
+

.github/workflows/test.yml

@@ -28,40 +28,39 @@ jobs:
             build_type: 'Debug'
 
     steps:
-    - uses: actions/checkout@v2
-      with:
-        submodules: recursive
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
-    - name: setup (ubuntu)
-      if: ${{ matrix.os == 'ubuntu-latest' }}
-      run:
-        sudo apt install ninja-build
+      - name: setup (ubuntu)
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run:
+          sudo apt install ninja-build
 
-    - name: setup (macos)
-      if: ${{ matrix.os == 'macos-latest' }}
-      run: |
-        brew update
-        brew install ninja
+      - name: setup (macos)
+        if: ${{ matrix.os == 'macos-latest' }}
+        run: |
+          brew update
+          brew install ninja
 
-    - name: Configure
-      run: >
-        cmake
-        -G "${{ matrix.generator }}"
-        -B "${{github.workspace}}/build"
-        -DCMAKE_BUILD_TYPE="${{matrix.build_type}}"
-        -DCLASP_BUILD_TESTS="On"
-        -DCLASP_BUILD_WITH_THREADS="${{matrix.build_threads}}"
-        -DLIB_POTASSCO_BUILD_TESTS="On"
-        -DCMAKE_CXX_STANDARD="14"
+      - name: Configure
+        run: >
+          cmake
+          -G "${{ matrix.generator }}"
+          -B "${{github.workspace}}/build"
+          -DCMAKE_BUILD_TYPE="${{matrix.build_type}}"
+          -DCLASP_BUILD_WITH_THREADS="${{matrix.build_threads}}"
+          -DCLASP_BUILD_TESTS="On"
+          -DLIB_POTASSCO_BUILD_TESTS="On"
 
-    - name: Build
-      run: >
-        cmake
-        --build "${{github.workspace}}/build"
-        --config "${{matrix.build_type}}"
+      - name: Build
+        run: >
+          cmake
+          --build "${{github.workspace}}/build"
+          --config "${{matrix.build_type}}"
 
-    - name: Test
-      working-directory: ${{github.workspace}}/build
-      run: >
-        ctest
-        -C "${{matrix.build_type}}"
+      - name: Test
+        working-directory: ${{github.workspace}}/build
+        run: >
+          ctest  --rerun-failed --output-on-failure
+          -C "${{matrix.build_type}}"

.gitignore

@@ -2,3 +2,4 @@
 build*
 .vscode*
 CMakeLists.txt.user
+cmake-build*

.gitmodules

@@ -1,3 +1,3 @@
 [submodule "libpotassco"]
 	path = libpotassco
-	url = https://github.com/potassco/libpotassco.git
+	url = ../libpotassco.git