Skip to content

Conversation

@pow2clk
Copy link
Owner

@pow2clk pow2clk commented Apr 3, 2025

Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

As this file was easily mistaken for applying to the golden rule: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly it is at serious risk of receiving changes that will get hung up by requirements to follow the LLVM coding guidelines. This brings the cases where variable capitalization is not in line with the coding standards to avoid such pitfalls in the future.

Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly

As this file was easily mistaken for applying to the golden rule:
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
it is at serious risk of receiving changes that will get hung up by
requirements to follow the LLVM coding guidelines. This brings the cases
where variable capitalization is not in line with the coding standards
to avoid such pitfalls in the future.
@pow2clk pow2clk closed this Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 048f18e896a4817e8b895861cc171872d4f6815c 415e3a9f069809663e8fd267da689dbc91130d8f -- lib/DxilValidation/DxilValidation.cpp
View the diff from clang-format here.
diff --git a/lib/DxilValidation/DxilValidation.cpp b/lib/DxilValidation/DxilValidation.cpp
index 8fa89dcb..f25208e7 100644
--- a/lib/DxilValidation/DxilValidation.cpp
+++ b/lib/DxilValidation/DxilValidation.cpp
@@ -4269,7 +4269,7 @@ static void ValidateSignatureElement(DxilSignatureElement &SE,
   case DXIL::SemanticKind::DomainLocation:
   case DXIL::SemanticKind::Invalid:
     DXASSERT(!AllowedInSig, "else internal inconsistency between semantic "
-                             "interpretation table and validation code");
+                            "interpretation table and validation code");
     break;
   case DXIL::SemanticKind::Barycentrics:
     IsBarycentric = true;
  • Check this box to apply formatting changes to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant