30-bit bus interaction ID #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raction (odd case)
…ion-optional-helper
…interaction-update
Schaeff
approved these changes
Feb 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
Depends on #2474, which depends on #2465. Added a test for new API `bus_multi_batch_lookup_permutation` per @Schaeff's suggestion. This currently invokes the API in a raw way, so I will add more tests in another PR that uses permutation and lookup syntaxs in block machine to conduct integrated test of our linker infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2470. Depends on #2465. Approval will only works after merging #2465.
The following is a response to #2470 and motivation of this PR:
Chance of collission:
For 24-bits:
100 interactions: 0.000295000053831429
1000 interactions: 0.02933425835911685
10000 interactions: 0.9492338975723106
For 30-bits (theoretically the largest we could get to without changing pil code due to field prime of bb and m31):
100 interactions: 4.610036260510597e-06
1000 interactions: 0.0004650875835883195
10000 interactions: 0.04549425469529611
Neither look ideal, but I think after #2469, bus linker mode should always have 2 bus interactions only. For user defined bus interactions, they can intentionally input IDs that don't clash, so I think just using 30-bit interaction id should be good enough for 29 bits of security (under 2 interactions linker case).