Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2539
With this PR, there is no more
.unwrap()
onBusSend::static_bus_id()
(previouslybus_id()
) andBusSend::try_match_static()
.Note that this will only generate a machine call when the bus ID is "known concrete". Getting there might require branching. To relax this (and require only known, but not concrete), I think we could change
Effect::MachineCall
to take a symbolic expression instead of a concrete value, butCanProcessCall::can_process_call_fully()
still expects a concrete value, which can't easily be changed, so I think this is the best we can do.