-
Notifications
You must be signed in to change notification settings - Fork 116
Update openvm to 1.4.0 #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update openvm to 1.4.0 #3291
Conversation
…f, but can't get column names
[Ovm 1.4] get original airs
[OVM 1.4] `VmConfig` related trait implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Still doing the review, these are some initial comments
openvm-stark-backend = { git = "https://github.com/powdr-labs/stark-backend.git", rev = "e27de8b", default-features = false, features = [ | ||
"parallel", | ||
"jemalloc", | ||
"bench-metrics", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bench-metrics
not needed anymore for metrics.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i see the feature doesn't exist anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the backend metrics are not being generated anymore, this will break our scripts/nightly?
is there a different way of getting them now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed now: powdr_openvm now has a metrics
flag, which activates metrics
on its dependencies. cli_openvm
has one as well, which is on by default.
This PR updated the openvm dependency to 1.4.0. A lot of changes were introduced, hence the size of this PR.
Not covered in this PR:
Changes to openvm here
Changes to stark-backend here
Tasks:
Send + Sync
bound on Executor in ovm (instead, removed the need for that bound in ovm)