Skip to content

Conversation

qwang98
Copy link
Collaborator

@qwang98 qwang98 commented Sep 17, 2025

This PR updated the openvm dependency to 1.4.0. A lot of changes were introduced, hence the size of this PR.

Not covered in this PR:

  • gpu: this PR brings us to parity with existing functionality, so only CPU is supported. See [Ovm GPU] WIP feature branch #3347 for GPU support.
  • plonk: since the main proving route for openvm is using a single row, plonk support was deprioritized for now and will be eventually fixed in another PR.

Changes to openvm here
Changes to stark-backend here

Tasks:

  • make compile
  • pil export test
  • implement all extensions (Circuit, Executor, (Prover))
  • make tracegen work
  • re-enable Send + Sync bound on Executor in ovm (instead, removed the need for that bound in ovm)
  • support tco flag

@qwang98 qwang98 marked this pull request as draft September 17, 2025 05:51
[OVM 1.4] `VmConfig` related trait implementations
@Schaeff Schaeff changed the title [DO NOT MERGE] discussion board for OVM-1.4 Update openvm to 1.4.0 Oct 13, 2025
@Schaeff Schaeff marked this pull request as ready for review October 13, 2025 10:42
Copy link
Collaborator

@pacheco pacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Still doing the review, these are some initial comments

openvm-stark-backend = { git = "https://github.com/powdr-labs/stark-backend.git", rev = "e27de8b", default-features = false, features = [
"parallel",
"jemalloc",
"bench-metrics",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bench-metrics not needed anymore for metrics.json?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i see the feature doesn't exist anymore

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the backend metrics are not being generated anymore, this will break our scripts/nightly?
is there a different way of getting them now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now: powdr_openvm now has a metrics flag, which activates metrics on its dependencies. cli_openvm has one as well, which is on by default.

@Schaeff Schaeff mentioned this pull request Oct 14, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants