Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Detecting geometrical shapes using opencv #247

Merged
merged 10 commits into from
Sep 17, 2020

Conversation

simarpreetsingh-019
Copy link
Contributor

@simarpreetsingh-019 simarpreetsingh-019 commented Sep 3, 2020

Detecting geometrical shapes using opencv in python added.

This Pr is in reference to issue #93 being assigned to me with label as Medium and CH20. would create readme also in some time.
Please review.
#93 (comment)

Detecting geometrical shapes using opencv in python added.
Copy link

@disha2sinha disha2sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare a README.md file with brief description of your work,libraries used and outputs

cv2.waitKey(0)
cv2.destroyAllWindows()


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, will be updating by morning on all these.

Removed extra new lines from the code.
Created Readme.md for this repo.
Updated readme.md with correction of showing input and output image
Copy link

@disha2sinha disha2sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove issue #246 and link this PR to issue #93

@simarpreetsingh-019
Copy link
Contributor Author

@disha2sinha only the ones with admin access can remove or delete that issue 246, so I am not able to do so, maybe you or someone with admin rights can do that.

Copy link

@disha2sinha disha2sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah by remove I meant close.....my fault

@simarpreetsingh-019
Copy link
Contributor Author

ohh , no problem, I have already closed them.
is it ready for merge?

Created and implemented Canny Edge Detection math.py  using mathematics.
Readme for this file is created. Uploading images soon.
Readme for canny edge detection fully updated and ready for merge.
@powerexploit powerexploit merged commit e0627bb into powerexploit:master Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants