Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Basic open cv #98

Closed
wants to merge 5 commits into from
Closed

Basic open cv #98

wants to merge 5 commits into from

Conversation

ryuk156
Copy link
Contributor

@ryuk156 ryuk156 commented Aug 15, 2020

Issue : #93

About Pull Request :
Created a basic script how we are going to install OpenCV and how we are going to read images in OpenCV and how to get image details and how to display images
Updated image processing Readme file

Output of script[Screenshot] :
image

@ryuk156
Copy link
Contributor Author

ryuk156 commented Aug 15, 2020

@disha2sinha Review Please and I have made this basic pr because before some visit repo he/she should how to get install and some basic knowledge

Copy link
Owner

@powerexploit powerexploit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryuk156 remove installation commands you explained in the starting of script.

@ryuk156
Copy link
Contributor Author

ryuk156 commented Aug 16, 2020

@ankitdobhal done Review , please and merge

@powerexploit
Copy link
Owner

@ankitdobhal done Review , please and merge

Thank you for your contribution @ryuk156
Before I approve changes to the PR, I will request you the following changes mentioned below.

Add README (guide) along with this inside the folder same as your
Update the README with appropriate installation methods and description guidelines.
Maintain proper Contribution protocols protocols (ignore if you're already following it!) & good practices!

Rest LGTM

@ryuk156
Copy link
Contributor Author

ryuk156 commented Aug 17, 2020

@ankitdobhal done

@powerexploit
Copy link
Owner

powerexploit commented Aug 19, 2020

Good job @ryuk156

But @ryuk156 read the guidelines clearly .
You have to create new folder inside Image-Processing folder and put your script and README file.
Readme file will contain information of your script.
Thanks.

@ryuk156 ryuk156 closed this Aug 19, 2020
@ryuk156 ryuk156 deleted the Basic-Open-CV branch August 19, 2020 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants