Skip to content

Commit

Permalink
Revert "[PLAY-1821] Home Address Casing" (#4227)
Browse files Browse the repository at this point in the history
Reverts #4176
  • Loading branch information
nidaqg authored Feb 4, 2025
1 parent 1359250 commit 7e80bab
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 60 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ type HomeAddressStreetProps = {
className?: string,
data?: { [key: string]: string },
dark?: boolean,
preserveCase?: boolean,
emphasis: "street" | "city" | "none",
htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
homeId: string,
Expand All @@ -44,7 +43,6 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
htmlOptions = {},
homeId,
homeUrl,
preserveCase = false,
target,
newWindow,
houseStyle,
Expand Down Expand Up @@ -79,8 +77,6 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
return null
}

const formatStreetAdr = (address: string): string => preserveCase ? address : titleize(address)

return (
<div
className={classes(className, dark)}
Expand All @@ -95,7 +91,7 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
dark={dark}
size={4}
>
{joinPresent([formatStreetAdr(address), houseStyle], ' · ')}
{joinPresent([titleize(address), houseStyle], ' · ')}
</Title>
<Title
className="pb_home_address_street_address"
Expand All @@ -105,14 +101,14 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
{titleize(addressCont)}
</Title>
<Body color="light">
{`${titleize(city)}, ${state.toUpperCase()} ${zipcode}`}
{`${titleize(city)}, ${state} ${zipcode}`}
</Body>
</div>
}
{emphasis == 'city' &&
<div>
<Body color="light">
{joinPresent([formatStreetAdr(address), houseStyle], ' · ')}
{joinPresent([titleize(address), houseStyle], ' · ')}
</Body>
<Body color="light">{titleize(addressCont)}</Body>
<div>
Expand All @@ -122,7 +118,7 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
size={4}
tag="span"
>
{`${titleize(city)}, ${state.toUpperCase()}`}
{`${titleize(city)}, ${state}`}
</Title>
<Body
color="light"
Expand All @@ -136,15 +132,15 @@ const HomeAddressStreet = (props: HomeAddressStreetProps): React.ReactElement =>
{emphasis == 'none' &&
<div>
<Body dark={dark}>
{joinPresent([formatStreetAdr(address), houseStyle], ' · ')}
{joinPresent([titleize(address), houseStyle], ' · ')}
</Body>
<Body dark={dark}>{formatStreetAdr(addressCont)}</Body>
<Body dark={dark}>{titleize(addressCont)}</Body>
<div>
<Body
color="light"
dark={dark}
>
{`${titleize(city)}, ${state.toUpperCase()} ${zipcode}`}
{`${titleize(city)}, ${state} ${zipcode}`}
</Body>
</div>
</div>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ examples:
- home_address_street_emphasis: Emphasis
- home_address_street_modified: Modified
- home_address_street_link: Link
- home_address_street_formatting: Formatting

react:
- home_address_street_default: Default
- home_address_street_emphasis: Emphasis
- home_address_street_modified: Modified
- home_address_street_link: Link
- home_address_street_formatting: Formatting

swift:
- home_address_street_default_swift: Default
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ export { default as HomeAddressStreetDefault } from './_home_address_street_defa
export { default as HomeAddressStreetEmphasis } from './_home_address_street_emphasis.jsx'
export { default as HomeAddressStreetModified } from './_home_address_street_modified.jsx'
export { default as HomeAddressStreetLink } from './_home_address_street_link.jsx'
export { default as HomeAddressStreetFormatting } from './_home_address_street_formatting.jsx'
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ class HomeAddressStreet < Playbook::KitBase
prop :state
prop :zipcode
prop :territory
prop :preserve_case, default: false
prop :dark, type: Playbook::Props::Boolean, default: false

def classname
Expand All @@ -30,15 +29,15 @@ def city_state_zip
end

def city_state
[city&.titleize, state&.upcase].join(", ")
[city&.titleize, state].join(", ")
end

def zip
zipcode.to_s
end

def address_house_style
[format_street_address, house_style].join(separator)
[address&.titleize, house_style].join(separator)
end

def address_house_style2
Expand All @@ -49,14 +48,6 @@ def separator
house_style ? " \u00b7 " : ""
end

def format_street_address
preserve_case ? address : custom_titleize(address)
end

def custom_titleize(str)
str.split(" ").map(&:capitalize).join(" ")
end

def city_emphasis_props
{
address_house_style: address_house_style,
Expand Down

0 comments on commit 7e80bab

Please sign in to comment.