Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1798] Enable Dark Mode in Loading Inline Text and Labels #4130

Merged
merged 2 commits into from
Jan 22, 2025
Merged

[PLAY-1798] Enable Dark Mode in Loading Inline Text and Labels #4130

merged 2 commits into from
Jan 22, 2025

Conversation

cmhorsey
Copy link
Contributor

@cmhorsey cmhorsey commented Jan 15, 2025 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.
Dark mode enabled in React Loading Inline kit page, all text and labels are now using $text_dk_light.

Story PLAY-1798

Screenshots: Screenshots to visualize your addition/change

Screenshot 2025-01-16 at 8 16 05 AM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@cmhorsey cmhorsey self-assigned this Jan 15, 2025
@cmhorsey cmhorsey added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Jan 16, 2025
@cmhorsey cmhorsey marked this pull request as ready for review January 16, 2025 13:21
@cmhorsey cmhorsey requested a review from a team as a code owner January 16, 2025 13:21
nidaqg
nidaqg approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Jan 17, 2025
@cmhorsey cmhorsey added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Jan 20, 2025
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Inactive RC Skip the release candidate process labels Jan 21, 2025
@jasperfurniss jasperfurniss merged commit c4a812a into master Jan 22, 2025
16 checks passed
@jasperfurniss jasperfurniss deleted the play-1798-dark-mode-loading-inline-audit branch January 22, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@kangaree kangaree kangaree approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@cmhorsey cmhorsey

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmhorsey @jasperfurniss @kangaree @nidaqg