Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1773] Rails input masking: credit_card and cvv #4150

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

kangaree
Copy link
Contributor

What does this PR do?

  • Continues work in PLAY-1772 (PLAY-1773).
  • Adds credit_card and cvv mask
  • Make mask prop an enum

Screenshots:
Screenshot 2025-01-22 at 8 43 32 AM

How to test?

  1. Go to /kits/text_input/rails#mask
  2. Type in the Credit Card and CVV text inputs
  3. They should be masked as you type

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Jan 22, 2025
@kangaree kangaree requested a review from a team as a code owner January 22, 2025 13:45
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1773-rails-input-masking-pt2

@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin Ready for Release merged to master, ready for a versioned released and removed Needs Review labels Jan 31, 2025
@kangaree kangaree removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 4, 2025
@nidaqg nidaqg removed the Ready for Release merged to master, ready for a versioned released label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants