-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-743] Advanced Table - Add Responsiveness to Rails kit #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
reviewed
Jan 22, 2025
nidaqg
reviewed
Jan 22, 2025
playbook/app/pb_kits/playbook/pb_advanced_table/table_header.html.erb
Outdated
Show resolved
Hide resolved
nidaqg
reviewed
Jan 22, 2025
playbook/app/pb_kits/playbook/pb_advanced_table/table_header.html.erb
Outdated
Show resolved
Hide resolved
nidaqg
reviewed
Jan 22, 2025
playbook/app/pb_kits/playbook/pb_advanced_table/table_header.rb
Outdated
Show resolved
Hide resolved
nidaqg
reviewed
Jan 23, 2025
nidaqg
previously approved these changes
Jan 23, 2025
nidaqg
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Approved
Approved by a Playbook Admin
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
Inactive RC
Skip the release candidate process
milano
20 MAX - Deploy this PR to a review environment via Milano
minor
Semver Target
Product Approved
pending technical review, OK to merge to master
Ready for Release
merged to master, ready for a versioned released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
As a Playbook dev,
I want to add Responsiveness to our Rails Advanced Table kit,
so that I can ensure parity between our Rails and React kits.
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.