Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-743] Advanced Table - Add Responsiveness to Rails kit #4151

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

skduncan
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
As a Playbook dev,
I want to add Responsiveness to our Rails Advanced Table kit,
so that I can ensure parity between our Rails and React kits.

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@skduncan skduncan added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Jan 22, 2025
@skduncan skduncan requested a review from a team as a code owner January 22, 2025 13:55
@skduncan skduncan added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 22, 2025
@skduncan skduncan added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 22, 2025
nidaqg
nidaqg previously approved these changes Jan 23, 2025
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Jan 23, 2025
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master labels Jan 27, 2025
@nidaqg nidaqg added the Inactive RC Skip the release candidate process label Jan 27, 2025
@skduncan skduncan merged commit 80ff989 into master Jan 28, 2025
7 checks passed
@skduncan skduncan deleted the PBNTR-743_rails_advance_table_responsive branch January 28, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants