Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1752] Implement pb_content_tag #4203

Merged
merged 4 commits into from
Feb 7, 2025
Merged

[PLAY-1752] Implement pb_content_tag #4203

merged 4 commits into from
Feb 7, 2025
+11 −54

Conversation

yuriyivanenko
Copy link
Contributor

@yuriyivanenko yuriyivanenko commented Jan 30, 2025 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.
Update Icon, Layout, Legend, Message kits to no longer use content_tag and use our new pb_content_tag

There should be no visible changes to the kits.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@yuriyivanenko yuriyivanenko self-assigned this Jan 30, 2025
@yuriyivanenko yuriyivanenko added minor Semver Target enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jan 30, 2025
@yuriyivanenko yuriyivanenko marked this pull request as ready for review January 30, 2025 21:40
@yuriyivanenko yuriyivanenko requested a review from a team as a code owner January 30, 2025 21:40
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.12.0.pre.alpha.play1752updatecontenttag5801

Your Alpha for NPM is 14.12.0-alpha.play1752updatecontenttag5801

markdoeswork
markdoeswork approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Feb 5, 2025
@yuriyivanenko yuriyivanenko removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 5, 2025
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master Inactive RC Skip the release candidate process labels Feb 7, 2025
@nidaqg nidaqg merged commit 7c5d08c into master Feb 7, 2025
27 checks passed
@nidaqg nidaqg deleted the play-1752-update-content-tag branch February 7, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloslimasd carloslimasd carloslimasd approved these changes

@markdoeswork markdoeswork markdoeswork approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@yuriyivanenko yuriyivanenko

Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuriyivanenko @carloslimasd @markdoeswork @nidaqg