Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1753] Update pb_content_tags #4217

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cmhorsey
Copy link
Contributor

@cmhorsey cmhorsey commented Feb 3, 2025

What does this PR do? A clear and concise description with your runway ticket url.
Update Multi Level Select, Nav, Online Status, Popover kits to no longer use content_tag and use our new pb_content_tag.

There should be no visible changes to the kits.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@cmhorsey cmhorsey added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 3, 2025
@cmhorsey cmhorsey self-assigned this Feb 3, 2025
@cmhorsey cmhorsey requested a review from a team as a code owner February 3, 2025 15:29
@cmhorsey cmhorsey added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 4, 2025
@cmhorsey cmhorsey added the alpha label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.12.0.pre.alpha.play1753updatepbcontenttags5889

Your Alpha for NPM is 14.12.0-alpha.play1753updatepbcontenttags5889

playbook/app/pb_kits/playbook/pb_nav/item.html.erb Outdated Show resolved Hide resolved
playbook/app/pb_kits/playbook/pb_nav/item.html.erb Outdated Show resolved Hide resolved
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Feb 11, 2025
@cmhorsey cmhorsey added alpha and removed alpha labels Feb 11, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.play1753updatepbcontenttags6060

Your Alpha for NPM is 14.13.0-alpha.play1753updatepbcontenttags6060

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.play1753updatepbcontenttags6065

Your Alpha for NPM is 14.13.0-alpha.play1753updatepbcontenttags6065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants