[PLAY-1887] Home Address with fix #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1887-home-address-fix |
yuriyivanenko
added
bug
yuriyivanenko
commented
Feb 4, 2025
playbook/app/pb_kits/playbook/pb_home_address_street/home_address_street.rb
Show resolved
Hide resolved
jasperfurniss
approved these changes
Feb 4, 2025
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.play1887homeaddressfix5910 Your Alpha for NPM is 14.12.0-alpha.play1887homeaddressfix5910 |
nidaqg
approved these changes
Feb 5, 2025
yuriyivanenko
removed
the
milano
nidaqg
added
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
This PR includes all the code from Story PR plus adds a nil check for custom_titleize so the app does not crash when we don't pass a home address prop
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.