Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-862]Testing Draggable Kit with Table Kit #4234

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Feb 5, 2025

Testing to see if we can use our Draggable kit with Table kit on Rails side

TLDR:

  • We can use it with the subcomponent structure, but we will need to add a tag prop for draggable_container AND draggable_item so we can set it to tbody and tr.
  • This is a good addition to the kit for the long run, we should add it on the React side as well
  • We can also build the draggable piece into the Table kit, but this should be enough to allow devs to use it
Screen.Recording.2025-02-05.at.12.27.46.PM.mov

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 5, 2025
@nidaqg nidaqg self-assigned this Feb 5, 2025
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=testing-draggable-with-table

@nidaqg nidaqg marked this pull request as ready for review February 6, 2025 16:53
@nidaqg nidaqg requested a review from a team as a code owner February 6, 2025 16:53
@nidaqg nidaqg added Inactive RC Skip the release candidate process Code Approved Approved by a Playbook Admin and removed Needs Review labels Feb 6, 2025
@nidaqg nidaqg merged commit e087920 into master Feb 6, 2025
14 checks passed
@nidaqg nidaqg deleted the testing-draggable-with-table branch February 6, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants