Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-559] Draggable Kit with Table Kit #4253

Merged
merged 8 commits into from
Feb 12, 2025
Merged

[PBNTR-559] Draggable Kit with Table Kit #4253

merged 8 commits into from
Feb 12, 2025

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Feb 10, 2025

Runway Story

This PR:

  • Creates the tag prop for the Draggable.Container and Draggable.Item subcomponents so they can be used as html table elements
  • Creates draggableContainer as a prop for Table.Body for easier use within Draggable kit
  • Creates draggableItem and dragId as props for Table.Row for easier use within Draggable kit
Screen.Recording.2025-02-10.at.9.02.38.PM.mov

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 10, 2025
@nidaqg nidaqg self-assigned this Feb 10, 2025
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-559

@nidaqg nidaqg changed the title [PBNTR-559] Drabble Kit with Table Kit [PBNTR-559] Draggable Kit with Table Kit Feb 10, 2025
@nidaqg nidaqg marked this pull request as ready for review February 11, 2025 02:09
@nidaqg nidaqg requested a review from a team as a code owner February 11, 2025 02:09
@nidaqg nidaqg added the alpha label Feb 11, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.PBNTR5596029

Your Alpha for NPM is 14.13.0-alpha.PBNTR5596029

ElisaShapiro
ElisaShapiro previously approved these changes Feb 11, 2025
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Inactive RC Skip the release candidate process labels Feb 11, 2025
@nidaqg nidaqg added alpha and removed alpha Inactive RC Skip the release candidate process labels Feb 12, 2025
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.PBNTR5596084

Your Alpha for NPM is 14.13.0-alpha.PBNTR5596084

@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released and removed Needs Review labels Feb 12, 2025
@nidaqg nidaqg merged commit 7581301 into master Feb 12, 2025
14 checks passed
@nidaqg nidaqg deleted the PBNTR-559 branch February 12, 2025 18:43
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.14.0.pre.rc.3
- NPM: 14.14.0-rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants