Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1884] Responsive Progress Pill #4260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yuriyivanenko
Copy link
Contributor

@yuriyivanenko yuriyivanenko commented Feb 11, 2025

What does this PR do? A clear and concise description with your runway ticket url.
Story
This PR makes our Progress Pill kit more responsive by setting the width of the pill to 100% of the container and the max-width: 45px which is our current fixed width. This will allow the pills to expand and shrink inside their container.

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-02-11 at 1 40 06 PM
Screenshot 2025-02-11 at 1 40 32 PM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@yuriyivanenko yuriyivanenko added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Feb 11, 2025
@yuriyivanenko yuriyivanenko self-assigned this Feb 11, 2025
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1884-progress-pill

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.13.0.pre.alpha.play1884progresspill6064

Your Alpha for NPM is 14.13.0-alpha.play1884progresspill6064

@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants