[PLAY-1851] Checkbox React Hook Form support #4262
Open
+113
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
enhancement
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1851checkboxreacthook |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.13.0.pre.alpha.play1851checkboxreacthook6083 Your Alpha for NPM is 14.13.0-alpha.play1851checkboxreacthook6083 |
kangaree
previously approved these changes
Feb 12, 2025
markdoeswork
commented
Feb 13, 2025
markdoeswork
force-pushed
the
play/1851_checkbox_react_hook
branch
from
6d72267 to
aaea70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1851
Review env https://pr4262.playbook.beta.hq.powerapp.cloud/kits/checkbox/react#react-hook-form
Adding support for react hook form in our input kits
React Hook form needs the ref field to be more flexible to pass its props to the input field, so i did that.
Wrapping a field in react-hook-form's
<controller/>element isn't the approach i went for. Because that is suppose to be used when you don't have access to thereffield.